Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: report error when container name already exists #1142

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Jan 9, 2023

What does this PR do?

Suggests to change the name or leave it blank (to have a generated name by the engine)

Screenshot/screencast of this PR

gG22zno6EK.mp4

What issues does this PR fix or reference?

Fixes #896

How to test this PR?

  1. Create a container with a given name
  2. Try to create again a container using the same name

you should have an error and unable to proceed until you change the name

Change-Id: Ib1cc5132c33a09a2304cf2c61c3373dc2912c0da
Signed-off-by: Florent Benoit fbenoit@redhat.com

Suggests to leave it blank also to have a generated name by the engine
fixes containers#896

Change-Id: Ib1cc5132c33a09a2304cf2c61c3373dc2912c0da
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Copy link
Contributor

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Was able to test this and it errors out when typing in the same name.

@cdrage cdrage merged commit a48aefd into containers:main Jan 10, 2023
@podman-desktop-bot podman-desktop-bot added this to the 0.11.0 milestone Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants