-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor resource details page #1923
Conversation
@benoitf still not ready to be reviewed. I opened this for a discussion and to have the code when opening new PRs. Second, I guess that by opening the console tab i should connect to the machine. Should we customize it as we do for the start/stop/delete actions so each provider can list it as a possible action, no? Maybe for the first iteration i would skip both, wdyt? |
to your first question yes it should be possible to edit. For example I can raise the CPU and memory allocated to my machine. It's just that it needs a restart of the machine ( podman extension should handle that) to the second question, we need enhancement on the provider side to enable that. Maybe a Terminal view and a way to register more actions ( than start stop delete) |
and yes for the first iteration, skip both |
efd95e5
to
64965c3
Compare
64965c3
to
373e4fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The log tab is always empty
There is no a log command for a machine to retrieve old logs. You see something only when you start/stop a machine and you have the tab opened or you have opened it before |
f409b3e
to
4b010eb
Compare
@jeffmaury updated the PR so that if any start/stop action is executed from PD you can read the logs. There is still a limitation though. If a machine is started outside PD there is no way to retrieve them. |
de7ce37
to
5892a03
Compare
e4e23e4
to
d91b7b2
Compare
@benoitf @cdrage @jeffmaury can some of you please give this a look? It's a bit old now.. I spend more time rebasing it that working on other stuff lol. Thank you!! |
I understand the way of changing lot of stuff everywhere, but contributing it back is lot easier for review/separate of concerns/changes to target a specific changeset |
2a357ca
to
38efd3c
Compare
261492d
to
2e1be58
Compare
2e1be58
to
c786bd2
Compare
@benoitf i guess this should be good for a review |
c786bd2
to
5d15491
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @lstocchi
Signed-off-by: lstocchi <lstocchi@redhat.com>
Signed-off-by: lstocchi <lstocchi@redhat.com>
Signed-off-by: lstocchi <lstocchi@redhat.com>
Signed-off-by: lstocchi <lstocchi@redhat.com>
Signed-off-by: lstocchi <lstocchi@redhat.com>
Signed-off-by: lstocchi <lstocchi@redhat.com>
Signed-off-by: lstocchi <lstocchi@redhat.com>
Signed-off-by: lstocchi <lstocchi@redhat.com>
Signed-off-by: lstocchi <lstocchi@redhat.com>
5d15491
to
8f1978d
Compare
What does this PR do?
This PR refactors the details page of a resource
Screenshot/screencast of this PR
What issues does this PR fix or reference?
it is part of #1337
How to test this PR?