Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor resource details page #1923

Merged
merged 10 commits into from
Jul 26, 2023

Conversation

lstocchi
Copy link
Contributor

@lstocchi lstocchi commented Apr 3, 2023

What does this PR do?

This PR refactors the details page of a resource

Screenshot/screencast of this PR

details-page

What issues does this PR fix or reference?

it is part of #1337

How to test this PR?

  1. open the settings -> resources page
  2. visit the details page of a resource

@lstocchi
Copy link
Contributor Author

lstocchi commented Apr 3, 2023

@benoitf still not ready to be reviewed. I opened this for a discussion and to have the code when opening new PRs.
First, should i allow users to edit the values? In the mockup i see. So after a change i save it? Should they be made when the engine is stopped, right? How do i know if something is not editable? I think we miss some info
image

Second, I guess that by opening the console tab i should connect to the machine. Should we customize it as we do for the start/stop/delete actions so each provider can list it as a possible action, no?

Maybe for the first iteration i would skip both, wdyt?

@benoitf
Copy link
Collaborator

benoitf commented Apr 3, 2023

to your first question yes it should be possible to edit. For example I can raise the CPU and memory allocated to my machine. It's just that it needs a restart of the machine ( podman extension should handle that)
First iteration = not editable like today ( or just before you introduced the resource page)

to the second question, we need enhancement on the provider side to enable that. Maybe a Terminal view and a way to register more actions ( than start stop delete)

@benoitf
Copy link
Collaborator

benoitf commented Apr 3, 2023

and yes for the first iteration, skip both

@lstocchi lstocchi force-pushed the i1337-detailsPage branch 6 times, most recently from efd95e5 to 64965c3 Compare April 17, 2023 10:02
@lstocchi lstocchi marked this pull request as ready for review April 17, 2023 10:04
@lstocchi lstocchi requested review from a team and benoitf as code owners April 17, 2023 10:04
@lstocchi lstocchi requested review from jeffmaury and cdrage and removed request for a team April 17, 2023 10:04
Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The log tab is always empty

@lstocchi
Copy link
Contributor Author

The log tab is always empty

There is no a log command for a machine to retrieve old logs. You see something only when you start/stop a machine and you have the tab opened or you have opened it before

@lstocchi lstocchi force-pushed the i1337-detailsPage branch 3 times, most recently from f409b3e to 4b010eb Compare April 30, 2023 21:20
@lstocchi
Copy link
Contributor Author

@jeffmaury updated the PR so that if any start/stop action is executed from PD you can read the logs. There is still a limitation though. If a machine is started outside PD there is no way to retrieve them.

@lstocchi lstocchi requested a review from jeffmaury April 30, 2023 21:22
@lstocchi lstocchi force-pushed the i1337-detailsPage branch 3 times, most recently from de7ce37 to 5892a03 Compare May 29, 2023 14:30
@lstocchi lstocchi force-pushed the i1337-detailsPage branch 2 times, most recently from e4e23e4 to d91b7b2 Compare June 14, 2023 09:30
@lstocchi
Copy link
Contributor Author

@benoitf @cdrage @jeffmaury can some of you please give this a look? It's a bit old now.. I spend more time rebasing it that working on other stuff lol. Thank you!!

@benoitf
Copy link
Collaborator

benoitf commented Jun 14, 2023

should we have breadcrumb like in container details page ?
(top left corner)
(could be probably follow-up PR)
image

When clicking on the details of a podman machine, I'm always getting to the details of the same machine

fGCZT6IlAc.mp4

If I click on start inside kind provider, I don't have any log but terminal is scrolling and scrolling and scrolling but I don't see anything

QDOPKathvn.mp4

@benoitf
Copy link
Collaborator

benoitf commented Jul 19, 2023

I understand the way of changing lot of stuff everywhere, but contributing it back is lot easier for review/separate of concerns/changes to target a specific changeset

@lstocchi
Copy link
Contributor Author

@benoitf i guess this should be good for a review

Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @lstocchi

Signed-off-by: lstocchi <lstocchi@redhat.com>
Signed-off-by: lstocchi <lstocchi@redhat.com>
Signed-off-by: lstocchi <lstocchi@redhat.com>
Signed-off-by: lstocchi <lstocchi@redhat.com>
Signed-off-by: lstocchi <lstocchi@redhat.com>
Signed-off-by: lstocchi <lstocchi@redhat.com>
Signed-off-by: lstocchi <lstocchi@redhat.com>
Signed-off-by: lstocchi <lstocchi@redhat.com>
Signed-off-by: lstocchi <lstocchi@redhat.com>
Signed-off-by: lstocchi <lstocchi@redhat.com>
@benoitf benoitf enabled auto-merge (squash) July 26, 2023 07:24
@benoitf benoitf merged commit 2486e7c into containers:main Jul 26, 2023
8 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.3.0 milestone Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants