fix: add check before writing to terminal #3263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lstocchi <lstocchi@redhat.com>
lstocchi
requested review from
jeffmaury and
cdrage
and removed request for
a team
benoitf
reviewed
Jul 19, 2023
Signed-off-by: lstocchi <lstocchi@redhat.com>
benoitf
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes the writeToTerminal more robust by filtering invalid values and managing arrays of arrays (i don't have the error i faced but it happened when working with logs).
The behavior should be like before as if it receive a valid array of string nothing changes
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
it is part of the splitting of #1923
How to test this PR?