feat: Telemetry prompt in Welcome page #1927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving the telemetry prompt from a standalone dialog to a section in the Welcome page. This indirectly fixes the problem of the prompt appearing underneath the main window on some OSes and provides a more natural experience. The telemetry prompt enablement is intentionally independent from the welcome, so for example: - New users will see the welcome with telemetry. - Someone who used an older release (e.g. 0.11, prior to welcome) will have already responded to telemetry, so they will see the welcome without it. - If we improve the welcome in a future release, likewise new users would see both but upgrading users wouldn't be prompted for telemetry again. Implementation notes: - Extracted telemetry constants into a settings file so that they can be used elsewhere cleanly. - Removed telemetry dialog and exposed configureTelemetry() to trigger the telemetry system. - The render layer needs to be able to access the trigger, so I exposed it to the window via index.ts. - Added functions to welcome-utils.ts to check if we need to prompt for telemetry, and save the result. - Added new section to WelcomePage and reformatted the container engines to match design. - Added tests to verify when telemetry section appears. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
requested review from
jeffmaury,
lstocchi and
mairin
and removed request for
a team
|
👍 |
dylanmtaylor
approved these changes
Apr 4, 2023
benoitf
reviewed
Apr 4, 2023
Fixed formatting (added braces) and renamed enableTelemetry() to setTelemetry(). Signed-off-by: Tim deBoer <git@tdeboer.ca>
benoitf
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Moving the telemetry prompt from a standalone dialog to a section in the Welcome page. This indirectly fixes the problem of the prompt appearing underneath the main window on some OSes and provides a more natural experience.
The telemetry prompt enablement is intentionally independent from the welcome, so for example:
Implementation notes:
Screenshot/screencast of this PR
What issues does this PR fix or reference?
Issue #664.
How to test this PR?
To see the welcome and telemetry prompt again, delete the configuration file (e.g. .local/share/containers/podman-desktop/configuration/settings.json on Mac) or remove the telemetry and welcome settings.