feat: Allow Podman machine create with root privileges #2427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes containers#2078 Signed-off-by: Jeff MAURY <jmaury@redhat.com>
benoitf
reviewed
May 10, 2023
| }, | ||
| "podman.factory.machine.rootful": { | ||
| "type": "boolean", | ||
| "scope": "ContainerProviderConnectionFactory", |
There was a problem hiding this comment.
Suggested change
| "scope": "ContainerProviderConnectionFactory", | |
| "scope": "ContainerProviderConnectionFactory", | |
| "default": true, |
If I remember, we wanted to have rootful machines by default (as on macOS/Windows there is already a VM doing isolation) and it works better (less limitation in rootful environment)
benoitf
approved these changes
May 10, 2023
benoitf
reviewed
May 10, 2023
| spyExecPromise.mockImplementation(() => { | ||
| return Promise.resolve(''); | ||
| }); | ||
| extension.createMachine( |
Signed-off-by: Jeff MAURY <jmaury@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2078
What does this PR do?
Add a new flag to allow Podman machine to be created with root privileges
Screenshot/screencast of this PR
What issues does this PR fix or reference?
Fixes #2078
How to test this PR?