-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show warnings on pod creation and two containers use the same port (#2240) #2671
Conversation
…ort (containers#2240) Signed-off-by: lstocchi <lstocchi@redhat.com>
+1 on the function. I don't love banner warning UI and it doesn't match anything else (because we don't have a similar issue anywhere else yet), but we could always get design input and change it later. |
I see where you got the design idea for the Possible Runtime Error alert message... it looks like the Patternfly alert, but it's too bright I think for our theme. I created one of these for the OpenShift Local mockup, looks like this: I think a similar look could work a little better here. (I will mock smtg up, will post later today) |
I copied the alert notification from the tailwindcss page https://v1.tailwindcss.com/components/alerts#left-accent-border
Much much better, thanks!! I'll update the PR to this 🙏 |
Signed-off-by: lstocchi <lstocchi@redhat.com>
Done. You can see the result in the gif https://user-images.githubusercontent.com/49404737/242282201-241ee8e5-129f-413d-9009-9e1dcfcf78a8.gif |
That looks fantastic @lstocchi!!! |
Signed-off-by: lstocchi <lstocchi@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lstocchi was able to test this out and it warned correctly when using the same port against a wordpress + another wordpress container + mysql setup.
Code looks good too.
LGTM!
What does this PR do?
This PR proposes a way to guide users in case they try to create a pod with multiple containers and two or more of them use the same port
Screenshot/screencast of this PR
What issues does this PR fix or reference?
it resolves #2240
How to test this PR?