feat: add warning dialog message that virtual machine has low memory limit #2822
Conversation
vzhukovs
requested review from
jeffmaury and
cdrage
and removed request for
a team
|
Is it possible to embed this as a warning like PR #2671 instead of waiting until the user clicks Create? I think this text would be a little clearer: "It is recommend to install Kind on a virtual machine with at least 6GB memory" |
Will try to do the same here |
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| consilienceCheck?(params: { [key: string]: any }): Promise<string[] | undefined>; |
There was a problem hiding this comment.
Hello, I would find another way. I have no clue if I implement something what would be a consilienceCheck
probably it should be an optional parameter of setContainerProviderConnectionFactory method. (or setKubernetesConnectionFactory method)
|
@deboer-tim like on the following mockup? |
|
Thank you, that banner is much better and more usable! The title 'Possible runtime error' is inconsistent with the icon though (is it an error or warning?), maybe something like 'Possible performance issue' or 'Virtual machine may be too small'. |
packages/renderer/src/lib/preferences/PreferencesProviderRendering.svelte
Outdated
Show resolved
Hide resolved
|
Tested and the prompt came up / I was able to continue and create it. Just minor edits and I'm unsure with regards to the check function? But otherwise the code LGTM and the prompt is better than the modal |
jeffmaury
added
kind/feature 💡
vzhukovs
force-pushed
the
pd#2145
branch
2 times, most recently
from
8f2f5db
to
faf2322
Compare
|
Lint tests are failing, but otherwise LGTM on the new changes. |
Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
What does this PR do?
The following changes request provides an additional confirmation dialog during kind creation request, if the particular container provider has lower than 6GB memory limit.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
Fixes #2145
How to test this PR?
Configure Podman or Docker with less than 6GB ram and try to create a Kind Cluster. You should be warned with the message that it could be better to have a configured virtual machine with more than 6GB ram.