feat: add restart button after enabling / disabling mac os compatibility

[cdrage]

feat: add restart button after enabling / disabling mac os compatibility

What does this PR do?

• Adds a button that will ask if the user if they'd like to restart the
  podman machine to enable compatibility mode

Screenshot/screencast of this PR

Screen.Recording.2023-06-13.at.2.36.57.PM.mov

What issues does this PR fix or reference?

Fixes #2406

How to test this PR?

1. Press the compatibility button while on Mac OS
2. Enable / Disable
3. At the end it should ask if you'd like to restart your podman machine
4. Click and it will restart.

[cdrage]

Tests added and ready for review!

[benoitf]

Tested but it looks like I'm in an infinite loop on disabling. It always prompts to disable and no dialog about restarting my machine

froKILe9N0.mp4

[cdrage]

@benoitf Can you try again? I've rebased and changed the order of the restart prompt, but I'm unable to reproduce it on my machine (it disables and then prompts right after).

[benoitf]

Tried but still in the same state

[benoitf]

Also, I was wondering if on macOS it could work with the touchID when I need to disable/enable instead of having to type my password

[cdrage]

Tried but still in the same state

Fixed!

I had:

const defaultMachine: MachineJSON = machines.find(machine => machine?.Name === 'Default');

Instead of:

const defaultMachine: MachineJSON = machines.find(machine => machine?.Default == true');

For finding the default machine.

It should work now 👍

[cdrage]

Also, I was wondering if on macOS it could work with the touchID when I need to disable/enable instead of having to type my password

I only found https://github.com/emilbayes/macos-touchid but it's really old.

The only other thing is perhaps using: https://davidwalsh.name/touch-sudo

[benoitf]

trying again, (and yes I'm not using the default machine)

about touch key I know there is a manual way of enabling it (editing pam modules) , was just thinking for 'default users'

[benoitf]

Got this time the restart dialog but then clicking on yes:

StatusBarItem.svelte:39 Uncaught (in promise) Error: Error: cannot start VM podman-machine-default. VM foo is currently running or starting: only one VM can be active at a time

(VM that was running before was foo vm)

[benoitf]

my usecase:

at least 2 podman machines, the default one and foo and foo is running

then I click on 'disable', it says it is disabled, I click on yes about restarting my machine and then got the message in console (nothing reported in the UI)

[cdrage]

my usecase:

at least 2 podman machines, the default one and foo and foo is running

then I click on 'disable', it says it is disabled, I click on yes about restarting my machine and then got the message in console (nothing reported in the UI)

Ah, it's trying to restart the one that's not default (since I don't specify the machine).

I'll update the PR. Thanks for testing this out. Totally forgot the use case of a machine not-set-as-default.

[benoitf]

I tested again but it looks like there is a problem

tooltip say : 'Enable' and when I click it says 'Disable' and before launching Podman Desktop I disabled the compatibility mode.

I would expect that I could enable if it's disabled

yPZjBvHDpL.mp4

[cdrage]

I tested again but it looks like there is a problem

tooltip say : 'Enable' and when I click it says 'Disable' and before launching Podman Desktop I disabled the compatibility mode.

I would expect that I could enable if it's disabled

yPZjBvHDpL.mp4

I was able to replicate this on the main branch, this is a bug not introduced by this PR so I've opened up issue: #2985

[benoitf]

I think I'm hitting also #2781 during the restart (two processes want to restart a machine) so probably need to be merged after #2942

[cdrage]

Ah yes you're right. In the console I'm seeing the error appear sometimes. Let's block this PR until #2942 is closed.

[cdrage]

ping @benoitf @lstocchi @jeffmaury ready for another review since #2942 has been merged in

[benoitf]

@cdrage do you have rebased the branch ? it seems not so could be easier if you rebase

[cdrage]

@cdrage do you have rebased the branch ? it seems not so could be easier if you rebase

Ah you're right. I didn't rebase yet. Just pushed it

[benoitf]

JmVBbghExC.mp4

wondering that if I failed to enable it, if I should have the prompt to restart the machine ?

[benoitf]

was able to disable/enable or enable/disable with a restart. It is now restarting the correct machine.

was just wondering for the previous comment, if I'm not able to enable or disable, I would expect to not be prompted to restart the machine but could be a follow-up

[cdrage]

I agree, I will assign #2985 to myself so we can fix that.- There's something odd happening with the tooltip / enable / disable.