nit: fix autostart not working

[cdrage]

nit: fix autostart not working

What does this PR do?

Fixes autostart not working correctly.

This bug occurs during onMount when ProviderConfigured.svelte is loaded
and does runProvider without checking the autostart configuration.

Very small change / nit.

Screenshot/screencast of this PR

Screen.Recording.2023-06-20.at.1.50.49.PM.mov

What issues does this PR fix or reference?

Fixes #2781

How to test this PR?

1. Disable autostart
2. Stop podman machine
3. Exit PD
4. Start PD, it should still stay stopped.

Signed-off-by: Charlie Drage charlie@charliedrage.com

[cdrage]

Tests failing, investigating fixed

[jeffmaury]

LGTM

[lstocchi]

There is a empty kind file which should be removed.

[deboer-tim]

Something has been nagging me, but please let me know if I'm misunderstanding. My main concern: why is there anything in onMount() in the first place?

If I have auto-start off, then shouldn't the provider only start based on a user action? (if the user action makes this page appear, also odd that onMount() would be used)
If I have auto-start on, then don't I want the provider to start even if I don't go to the dashboard? e.g. it should start if only the tray is open, or we have some future path like the protocol handler where the dashboard is not the first page I see.

It seems like the auto-start should be in a completely different place in either case (not tied to a particular UI page) and this onMount() doesn't exist.

[cdrage]

Something has been nagging me, but please let me know if I'm misunderstanding. My main concern: why is there anything in onMount() in the first place?

If I have auto-start off, then shouldn't the provider only start based on a user action? (if the user action makes this page appear, also odd that onMount() would be used) If I have auto-start on, then don't I want the provider to start even if I don't go to the dashboard? e.g. it should start if only the tray is open, or we have some future path like the protocol handler where the dashboard is not the first page I see.

It seems like the auto-start should be in a completely different place in either case (not tied to a particular UI page) and this onMount() doesn't exist.

100% agree and it's odd that it is there in the first place.. @lstocchi and I are having this discussion now on slack

[cdrage]

Something has been nagging me, but please let me know if I'm misunderstanding. My main concern: why is there anything in onMount() in the first place?

If I have auto-start off, then shouldn't the provider only start based on a user action? (if the user action makes this page appear, also odd that onMount() would be used) If I have auto-start on, then don't I want the provider to start even if I don't go to the dashboard? e.g. it should start if only the tray is open, or we have some future path like the protocol handler where the dashboard is not the first page I see.

It seems like the auto-start should be in a completely different place in either case (not tied to a particular UI page) and this onMount() doesn't exist.

So the TLDR on slack is that we require onMount() to exist in order to be able to initialize / interact with the user in terms of initializing each provider. For example, we have initialize and start for Podman / button interaction before we use startProvider().

Makes sense as future features we'd be able to ask the user / interact before actually launching.

I've updated the PR to draft and I'll push some new code.

[cdrage]

Ready for review!

"Run Podman" or "Run Provider" button's will appear when autostart is false and Podman Desktop appears for the first time.

All it needed was an update to runAtStart = autostart && initializationContext.mode === InitializeAndStartMode;

Ready for review @lstocchi

[lstocchi]

Ready for review!

"Run Podman" or "Run Provider" button's will appear when autostart is false and Podman Desktop appears for the first time.

All it needed was an update to runAtStart = autostart && initializationContext.mode === InitializeAndStartMode;

I still face the same issue. If i click on initialize and start i expect that it creates a machine and start it. But if the autostart flag is set to false, the machine is only created and not started.

the question is how it should work. Bc if the autostart flag has always priority then it works fine.

[benoitf]

I gave a quick look

@lstocchi My question is that it looks like the Dashboard page initialize a map called providerInitContexts setting the mode to { mode: InitializeAndStartMode }; without any user action so ProviderConfigured will always see mode is InitializeAndStartMode and will run the machine

I'm wondering why we initialize data to InitializeAndStartMode I suppose the value should be set only if user click on 'Init' or 'Init and Start' (this is what is done but it is also the default value??) and then we should initialize the context to something 'empty/none/do nothing'

like in Dashboard.svelte:

    context = { mode: DoNothingMode };

and ProviderInitUtils having

export const DoNothingMode = 'DoNothing';
export const InitializeOnlyMode = 'Initialize';
export const InitializeAndStartMode = 'Initialize and start';
export type InitializationMode = typeof NoneMode |typeof InitializeOnlyMode | typeof InitializeAndStartMode;

[cdrage]

Ready for review!
"Run Podman" or "Run Provider" button's will appear when autostart is false and Podman Desktop appears for the first time.
All it needed was an update to runAtStart = autostart && initializationContext.mode === InitializeAndStartMode;

I still face the same issue. If i click on initialize and start i expect that it creates a machine and start it. But if the autostart flag is set to false, the machine is only created and not started.

the question is how it should work. Bc if the autostart flag has always priority then it works fine.

We have no way of knowing if it's been started for the first time, so I think we'd have to update the dashboard with a new value similar to Initialize and Start, what do you think?

EDIT: I see @benoitf and I commented at the same time. I'll update this PR so that we add a new value of "DoNothing" and only apply Init / Init and start when the user actually clicks the value.

[lstocchi]

I gave a quick look

@lstocchi My question is that it looks like the Dashboard page initialize a map called providerInitContexts setting the mode to { mode: InitializeAndStartMode }; without any user action so ProviderConfigured will always see mode is InitializeAndStartMode and will run the machine

I'm wondering why we initialize data to InitializeAndStartMode I suppose the value should be set only if user click on 'Init' or 'Init and Start' (this is what is done but it is also the default value??) and then we should initialize the context to something 'empty/none/do nothing'

like in Dashboard.svelte:

    context = { mode: DoNothingMode };

and ProviderInitUtils having

export const DoNothingMode = 'DoNothing';
export const InitializeOnlyMode = 'Initialize';
export const InitializeAndStartMode = 'Initialize and start';
export type InitializationMode = typeof NoneMode |typeof InitializeOnlyMode | typeof InitializeAndStartMode;

Correct. At that time i initialize it to InitializeAndStartMode as i didn't think it could cause any problem. But by changing the default value it should solve the issue

[cdrage]

Added DoNothing + changed the line to: runAtStart = autostart || initializationContext.mode === InitializeAndStartMode;

Tests done:

1. Disable autostart: When pressing initialize + start, podman starts correctly
2. Stop podman + restart podman desktop. Podman is still stopped.
3. Enable autostart, start podman desktop, Podman machine starts correctly

[cdrage]

Removed the lingering comment and have marked this as auto-merge