fix: allow single domain registry such as localhost:5000 #3468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What does this PR do? Allows you to add a registry such as "localhost:5000" for testing purposes, or domains without an LTD. You are able to do this through the podman/docker CLI, but not through podman desktop. ### Screenshot/screencast of this PR ### What issues does this PR fix or reference? Closes containers#3457 One of the fixes towards completing containers#3252 ### How to test this PR? 1. Add a test registry such as "localhost:5000" 2. You'll now get an error for login instead of 'The format of the Registry Location is incorrect' <!-- Please explain steps to reproduce --> Signed-off-by: Charlie Drage <charlie@charliedrage.com>
cdrage
requested review from
dgolovin and
jeffmaury
and removed request for
a team
This was referenced Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: allow single domain registry such as localhost:5000
What does this PR do?
Allows you to add a registry such as "localhost:5000" for testing
purposes, or domains without an LTD.
You are able to do this through the podman/docker CLI, but not through
podman desktop.
Screenshot/screencast of this PR
You'll now get an error for login / be able to actually add the registry instead of a format error.
What issues does this PR fix or reference?
Closes #3457
One of the fixes towards completing #3252
How to test this PR?
Registry Location is incorrect'
Signed-off-by: Charlie Drage charlie@charliedrage.com