fix: allow BASIC authentication (all caps) #3471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What does this PR do? Allows registries that have BASIC in the header instead of Basic to be extractable using the extractAuthData function. ### Screenshot/screencast of this PR <!-- Please include a screenshot or a screencast explaining what is doing this PR --> ### What issues does this PR fix or reference? <!-- Include any related issues from Podman Desktop repository (or from another issue tracker). --> Closes containers#3470 ### How to test this PR? 1. Deploy a Sonatype Nexus registry using: `podman run -d -p 8081:8081 -p 8082:8082 -p 443:443 --name nexus sonatype/nexus3` and setup an accesible docker registry 2. OR run a fake registry using this python script: https://gist.github.com/cdrage/07220d49e99ed54e0f5f0e3e6ab74758 3. Add the registry (example: localhost:8000) 4. You should now receive a timeout / authentication error rather than "Invalid URL" <!-- Please explain steps to reproduce --> Signed-off-by: Charlie Drage <charlie@charliedrage.com>
cdrage
requested review from
dgolovin and
jeffmaury
and removed request for
a team
benoitf
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: allow BASIC authentication (all caps)
What does this PR do?
Allows registries that have BASIC in the header instead of Basic to be
extractable using the extractAuthData function.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
Closes #3470
How to test this PR?
BEFORE TESTING:
Patch in #3468 to remove the invalid
The format of the Registry Location is incorrect. Or remove the line https://github.com/containers/podman-desktop/pull/3468/files#diff-18bc4f2318c7a0814b55328a4186d337972e6bcdd4c09b33d9b9353c47c2c5ffL713 before running.podman run -d -p 8081:8081 -p 8082:8082 -p 443:443 --name nexus sonatype/nexus3and setup an accesible docker registry"Invalid URL"
Signed-off-by: Charlie Drage charlie@charliedrage.com