Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow BASIC authentication (all caps) #3471

Merged
merged 1 commit into from Aug 10, 2023

Commits on Aug 9, 2023

  1. fix: allow BASIC authentication (all caps)

    ### What does this PR do?
    
    Allows registries that have BASIC in the header instead of Basic to be
    extractable using the extractAuthData function.
    
    ### Screenshot/screencast of this PR
    
    <!-- Please include a screenshot or a screencast
    explaining what is doing this PR -->
    
    ### What issues does this PR fix or reference?
    
    <!-- Include any related issues from Podman Desktop
    repository (or from another issue tracker). -->
    
    Closes containers#3470
    
    ### How to test this PR?
    
    1. Deploy a Sonatype Nexus registry using:
    `podman run -d -p 8081:8081 -p 8082:8082 -p 443:443 --name nexus sonatype/nexus3` and setup an accesible docker registry
    2. OR run a fake registry using this python script: https://gist.github.com/cdrage/07220d49e99ed54e0f5f0e3e6ab74758
    3. Add the registry (example: localhost:8000)
    4. You should now receive a timeout / authentication error rather than
       "Invalid URL"
    
    <!-- Please explain steps to reproduce -->
    
    Signed-off-by: Charlie Drage <charlie@charliedrage.com>
    cdrage committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    c3262cf View commit details
    Browse the repository at this point in the history