New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extend menus capabilities #3947
feat: extend menus capabilities #3947
Conversation
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the contrib
I think we're missing tests for
ContributionActions.svelte (to check if we're executing commands with correct args, how not-serializable args are filtered out)
Would be also nice for ContainerList
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
…rgs of ContributionActions Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like there is a regression in one of the existing unit test
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple of nits but thanks again @axel7083 for this nice enhancement 🎉
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Thanks @axel7083 !! 🚀 |
What does this PR do?
Thanks to @benoitf in #3938 (comment) I understood that it was possible to link a command to an item menu.
However, this features was only implemented for the Image List dashboard. I extended it to support the ContainersList dashboard as well.
Screenshot/screencast of this PR
Here is the contributes used to test this PR
What issues does this PR fix or reference?
Partially fix #3938
How to test this PR?