fix: ContainerList propagating containers in ComposeActions and PodActions #3963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
axel7083
requested review from
cdrage and
lstocchi
and removed request for
a team
cdrage
approved these changes
Sep 19, 2023
lstocchi
approved these changes
Sep 20, 2023
The ContainerList.svelte component is a bit complicated, so I do not see how to create an unit test in |
benoitf
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As discussed in #3947 the ContainerList now support Contribution Menu (menus from extensions).
This PR is a small fix, on the current implementations, the ComposeList svelte component does not propagate the containers in ComposeActions.
Since an extension can add a command, it may be useful to give them the full context, with the contains associate with the compose group.