feat: improved empty screens #3988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves the empty-screen message when the cause is a filter that doesn't match anything. The design requires adding second line in EmptyScreen, which I've done as a detail message. I then looked at making a *FilterEmptyScreen for each page as it's own component or inline, but there was a lot of copy/paste so I created a generic FilteredEmptyScreen. As per the design in issue #3602, when the filter is too long (I picked 20 chars) the search term isn't shown. searchTerm was already exported from ContainerList, I exported it from the others as well since it is necessary to test, and a useful feature in general. Tests added to show the filter empty screen comes up when the filter doesn't match anything. Fixes #3602. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
requested review from
jeffmaury and
lstocchi
and removed request for
a team
benoitf
approved these changes
Sep 20, 2023
Remove '.length > 0' and changed quotes to make linter happy with itself. Signed-off-by: Tim deBoer <git@tdeboer.ca>
benoitf
reviewed
Sep 20, 2023
benoitf
reviewed
Sep 20, 2023
Use '${searchTerm}', use '' to show detail type, and found another '.length>0'.
Signed-off-by: Tim deBoer <git@tdeboer.ca>
benoitf
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improves the empty-screen message when the cause is a filter that doesn't match anything.
The design requires adding second line in EmptyScreen, which I've done as a detail message. I then looked at making a *FilterEmptyScreen for each page as it's own component or inline, but there was a lot of copy/paste so I created a generic FilteredEmptyScreen. As per the design in issue #3602, when the filter is too long (I picked 20 chars) the search term isn't shown.
searchTerm was already exported from ContainerList, I exported it from the others as well since it is necessary to test, and a useful feature in general. Tests added to show the filter empty screen comes up when the filter doesn't match anything.
Screenshot/screencast of this PR
filter.mov
What issues does this PR fix or reference?
Fixes #3602.
How to test this PR?
Type a filter that matches (to confirm no regression), doesn't match (to confirm new behaviour), and is really long (to show the message changes).