Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improved empty screens #3988

Merged
merged 4 commits into from Sep 20, 2023
Merged

feat: improved empty screens #3988

merged 4 commits into from Sep 20, 2023

Commits on Sep 20, 2023

  1. feat: improved empty screens 

    Improves the empty-screen message when the cause is a filter that doesn't match
anything.

The design requires adding second line in EmptyScreen, which I've done as a
detail message. I then looked at making a *FilterEmptyScreen for each page as
it's own component or inline, but there was a lot of copy/paste so I created
a generic FilteredEmptyScreen. As per the design in issue #3602, when the filter
is too long (I picked 20 chars) the search term isn't shown.

searchTerm was already exported from ContainerList, I exported it from the
others as well since it is necessary to test, and a useful feature in general.
Tests added to show the filter empty screen comes up when the filter doesn't
match anything.

Fixes #3602.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
    @deboer-tim
    deboer-tim committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    4a1ef62 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into filter-empty

    @deboer-tim
    deboer-tim committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    736c4cc View commit details
    Browse the repository at this point in the history

  3. chore: simplify code and change quotes 

    Remove '.length > 0' and changed quotes to make linter happy with itself.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
    @deboer-tim
    deboer-tim committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    ee25e8d View commit details
    Browse the repository at this point in the history

  4. chore: lint feedback 

    Use '${searchTerm}', use '' to show detail type, and found another '.length>0'.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
    @deboer-tim
    deboer-tim committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    68b3cfd View commit details
    Browse the repository at this point in the history