Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: indeterminate progress bar #4016

Merged
merged 2 commits into from Sep 25, 2023

Conversation

axel7083
Copy link
Contributor

What does this PR do?

Adding indeterminate progress animation to the task with undefined progress.

Screenshot/screencast of this PR

Podman.Desktop.2023-09-21.15-57-09.mp4

What issues does this PR fix or reference?

As discussed in #4014

Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
@axel7083 axel7083 requested review from benoitf and a team as code owners September 21, 2023 14:05
@axel7083 axel7083 requested review from dgolovin and lstocchi and removed request for a team September 21, 2023 14:05
Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI we should have component test ( testing library) altogether with the changes/enhancement

Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
@benoitf benoitf merged commit e1715db into containers:main Sep 25, 2023
8 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.5.0 milestone Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants