Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding task progress for kind kind.image.move #4061

Merged

Conversation

axel7083
Copy link
Contributor

@axel7083 axel7083 commented Sep 24, 2023

What does this PR do?

Adding a progress task to the TASKS for loading an image to kind.

Screenshot/screencast of this PR

When loading

image

This will look way better when #4016 will be merged.

Finish loading

image

What issues does this PR fix or reference?

How to test this PR?

Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
@axel7083 axel7083 requested review from benoitf and a team as code owners September 24, 2023 09:06
@axel7083 axel7083 requested review from dgolovin and cdrage and removed request for a team September 24, 2023 09:06
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to include a test checking that we're calling extensionApi.window

Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
@benoitf benoitf merged commit bdcbcc2 into containers:main Sep 25, 2023
8 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.5.0 milestone Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants