feat: add when functionality for setting properties #4159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrage
requested review from
jeffmaury and
lstocchi
and removed request for
a team
cdrage
force-pushed
the
when-islinux-clauses-working-config
branch
2 times, most recently
from
8cfc68f
to
2f170ee
Compare
### What does this PR do? Adds the ability to use "when" statements for setting properties. For example, if you want to only show certain settings for certain operating systems by using `"when": "isLinux"`. ### Screenshot/screencast of this PR ### What issues does this PR fix or reference? Closes containers#4141 ### How to test this PR? Edit `extensions/podman/package.json` configuration for binary path to: ```json "podman.binary.path": { "type": "string", "format": "file", "default": "", "description": "Custom path to Podman binary (Default is blank)", "when": "isLinux" }, ``` When you check your preferences, it will now only show the binary path if you are running Linux. Signed-off-by: Charlie Drage <charlie@charliedrage.com>
cdrage
force-pushed
the
when-islinux-clauses-working-config
branch
from
2f170ee
to
10b7776
Compare
|
Found some issues in the way that we wrote the context testing previously, I've updated the tests and this is ready for review 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add when functionality for setting properties
What does this PR do?
Adds the ability to use "when" statements for setting properties.
For example, if you want to only show certain settings for certain
operating systems by using
"when": "isLinux".Screenshot/screencast of this PR
Screen.Recording.2023-09-29.at.11.31.43.AM.mov
What issues does this PR fix or reference?
Closes #4141
How to test this PR?
Edit
extensions/podman/package.jsonconfiguration for binary path to:When you check your preferences, it will now only show the binary path
if you are running Linux.
Signed-off-by: Charlie Drage charlie@charliedrage.com