Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add when functionality for setting properties #4159

Merged
merged 1 commit into from Oct 3, 2023

Commits on Sep 29, 2023

  1. feat: add when functionality for setting properties

    ### What does this PR do?
    
    Adds the ability to use "when" statements for setting properties.
    
    For example, if you want to only show certain settings for certain
    operating systems by using `"when": "isLinux"`.
    
    ### Screenshot/screencast of this PR
    
    ### What issues does this PR fix or reference?
    
    Closes containers#4141
    
    ### How to test this PR?
    
    Edit `extensions/podman/package.json` configuration for binary path to:
    
    ```json
            "podman.binary.path": {
              "type": "string",
              "format": "file",
              "default": "",
              "description": "Custom path to Podman binary (Default is blank)",
              "when": "isLinux"
            },
    ```
    
    When you check your preferences, it will now only show the binary path
    if you are running Linux.
    
    Signed-off-by: Charlie Drage <charlie@charliedrage.com>
    cdrage committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    10b7776 View commit details
    Browse the repository at this point in the history