Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding optional abort controller to dockerode api #4364

Merged

Conversation

axel7083
Copy link
Contributor

Related: #4363

What does this PR do?

Adding optional AbortController argument to functions with potentially long duration

…er-registry.ts

Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
@axel7083 axel7083 requested review from benoitf and a team as code owners October 16, 2023 19:04
@axel7083 axel7083 requested review from dgolovin and lstocchi and removed request for a team October 16, 2023 19:04
Copy link
Contributor

@lstocchi lstocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked with #4538

nice contribution @axel7083

just a minor nit

packages/main/src/plugin/container-registry.ts Outdated Show resolved Hide resolved
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
@benoitf benoitf merged commit 7942fc5 into containers:main Oct 30, 2023
9 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.6.0 milestone Oct 30, 2023
@axel7083 axel7083 mentioned this pull request Jan 24, 2024
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants