New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow to abort build image (#1655) #4538
Conversation
Nit: even though the underlying action is an abort, I think we generally use Cancel for buttons. |
Updated |
it looks like the PR check "linter, formatter, unit tests" is not passing |
we need to merge #4364 and rebase this one |
ok, I just tried this one and it was not working, cancel button was doing nothing :-) |
Nice @lstocchi !! |
Signed-off-by: lstocchi <lstocchi@redhat.com>
Signed-off-by: lstocchi <lstocchi@redhat.com>
I clicked on 'rebase the branch' button as dependent PR has been merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hey @lstocchi just wanted to let you know that the test It's probably caused by this
Maybe it should set the parameters back to the default after running the test? |
Thanks @jannikbertram !! |
What does this PR do?
This is built on #4364
It allows user to abort the build of an image
Screenshot/screencast of this PR
What issues does this PR fix or reference?
it closes #1655
How to test this PR?