refactor: updated compose onboarding installation #4479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrage
requested review from
dgolovin and
lstocchi
and removed request for
a team
cdrage
force-pushed
the
disable-linux-onboarding-compose
branch
2 times, most recently
from
92c7f34
to
694410f
Compare
|
I confirm that using next/next/next buttons I was able to use I also tried with just the binary being downloaded, aborting the install and resuming later (and also restart Podman Desktop) I'm just wondering if we should not kill the compose status bar icon ? I see a message "compose successfully downloaded" but in the status bar it's telling me that it's not downloaded ?
|
benoitf
approved these changes
Oct 24, 2023
cdrage
force-pushed
the
disable-linux-onboarding-compose
branch
from
7d942f2
to
318f5ff
Compare
cdrage
force-pushed
the
disable-linux-onboarding-compose
branch
from
318f5ff
to
694410f
Compare
### What does this PR do? * Installation is now Download which is more correct and files updated (installation.ts now download.ts) * Onboarding compose process is more flowing and streamlined, the system-wide install is now it's own step as it's required for onboarding * Updated documentation on how to use compose within the onboarding process ### Screenshot/screencast of this PR <!-- Please include a screenshot or a screencast explaining what is doing this PR --> ### What issues does this PR fix or reference? <!-- Include any related issues from Podman Desktop repository (or from another issue tracker). --> Closes containers#4475 Closes containers#4476 ### How to test this PR? Go through the onboarding process on a non-linux machine. If you are on a linux machine, you should NOT see the setup button anymore. <!-- Please explain steps to reproduce --> Signed-off-by: Charlie Drage <charlie@charliedrage.com>
cdrage
force-pushed
the
disable-linux-onboarding-compose
branch
from
694410f
to
fdee9eb
Compare
|
Updated the PR to not disable Linux onboarding. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: updated compose onboarding installation
What does this PR do?
(installation.ts now download.ts)
system-wide install is now it's own step as it's required for
onboarding
process
Screenshot/screencast of this PR
Screen.Recording.2023-10-23.at.8.23.10.PM.mov
What issues does this PR fix or reference?
Closes #4475
Closes #4476
How to test this PR?
Go through the onboarding process on a non-linux machine. If you are on
a linux machine, you should NOT see the setup button anymore.