Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove compose from the status bar #4492

Merged
merged 1 commit into from Oct 25, 2023

Conversation

cdrage
Copy link
Contributor

@cdrage cdrage commented Oct 24, 2023

refactor: remove compose from the status bar

What does this PR do?

Removes compose from the status bar since we are not implementing
onboarding.

This does NOT remove the excess code from compose-extension.ts yet.
This will be need to be cleaned up in the future.

Screenshot/screencast of this PR

N/A, should not appear anymore

What issues does this PR fix or reference?

Closes #3809

How to test this PR?

Signed-off-by: Charlie Drage charlie@charliedrage.com

@cdrage cdrage requested review from benoitf and a team as code owners October 24, 2023 12:37
@cdrage cdrage requested review from jeffmaury and feloy and removed request for a team October 24, 2023 12:37
Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works 👍

Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

### What does this PR do?

Removes compose from the status bar since we are not implementing
onboarding.

This does NOT remove the excess code from `compose-extension.ts` yet.
This will be need to be cleaned up in the future.

### Screenshot/screencast of this PR

<!-- Please include a screenshot or a screencast
explaining what is doing this PR -->

N/A, should not appear anymore

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes containers#3809

### How to test this PR?

<!-- Please explain steps to reproduce -->

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
@cdrage
Copy link
Contributor Author

cdrage commented Oct 25, 2023

Had to rebase and push again 👍

@benoitf benoitf merged commit a2557b9 into containers:main Oct 25, 2023
9 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.6.0 milestone Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "Compose" from status bar
4 participants