New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow image push to lima kubernetes cluster #4487
Conversation
783a76d
to
e12640e
Compare
A future addition should make it possible to configure the command being used to load images... Currently it uses a hardcoded But if it is possible to install a different container runtime and container engine, that could change:
i.e. |
e12640e
to
a3d9e0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late reply, but this works great! Took me a while to setup the cluster, so it took some time.
Thank you so much for the contribution. I was able to successfully push an image to the k8s cluster.
a3d9e0b
to
57328f1
Compare
looks like there is a conflict in the file |
Merge conflicts, because javascript is silly
@@@ -50,7 -64,6 +64,8 @@@
"devDependencies": {
"adm-zip": "^0.5.10",
"mkdirp": "^3.0.1",
+ "vite": "^5.0.10",
- "vitest": "^1.1.0"
++ "vitest": "^1.1.0",
+ "tmp-promise": "^3.0.3"
}
}
Due to not allowing trailing commas in lists. |
Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
57328f1
to
657488f
Compare
What does this PR do?
Screenshot/screencast of this PR
What issues does this PR fix or reference?
Closes #4486
How to test this PR?
This assumes that the cluster is using containerd...
If running cri-o, it would have to use
podman load
instead:sudo nerdctl -n k8s.io load -i
=>sudo podman load -i
But it is hardcoded the same way, in
kind load image-archive