New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: allow image push to lima kubernetes cluster #4488
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afbjorklund
requested review from
slemeur,
themr0c,
benoitf and
a team
as code owners
October 24, 2023 09:48
afbjorklund
requested review from
jeffmaury and
lstocchi
and removed request for
a team
October 24, 2023 09:48
themr0c
reviewed
Oct 24, 2023
website/docs/kubernetes/lima/building-an-image-and-testing-it-in-lima.md
Outdated
Show resolved
Hide resolved
themr0c
reviewed
Oct 24, 2023
website/docs/kubernetes/lima/working-with-your-local-lima-cluster.md
Outdated
Show resolved
Hide resolved
themr0c
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
This comment was marked as resolved.
This comment was marked as resolved.
This was referenced Oct 29, 2023
jeffmaury
reviewed
Nov 3, 2023
website/docs/kubernetes/lima/building-an-image-and-testing-it-in-lima.md
Outdated
Show resolved
Hide resolved
website/docs/kubernetes/lima/building-an-image-and-testing-it-in-lima.md
Outdated
Show resolved
Hide resolved
website/docs/kubernetes/minikube/building-an-image-and-testing-it-in-minikube.md
Outdated
Show resolved
Hide resolved
website/docs/kubernetes/minikube/working-with-your-local-minikube-cluster.md
Outdated
Show resolved
Hide resolved
The whole section is gone now, but I guess it would end up in a special submenu ? Like: https://podman-desktop.io/docs/kubernetes/kind/pushing-an-image-to-kind |
Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
afbjorklund
force-pushed
the
lima-push-docs
branch
from
November 5, 2023 12:06
c7a63f4
to
aa41a41
Compare
cdrage
approved these changes
Dec 8, 2023
benoitf
approved these changes
Dec 22, 2023
Thanks for the PR @afbjorklund |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Screenshot/screencast of this PR
What issues does this PR fix or reference?
How to test this PR?
Testing requires:
Most of these docs are identical between the Kubernetes providers.
Main difference is the thing about the ingress that is deployed on kind.