fix: allow table columns to specify overflow #5222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the previous table (<1.6), column widths were variable and this caused problems: - sometimes a long image name would cause the tables to require horizontal scrolling - sometimes a change in one column would cause other columns to shift E.g. starting a container can cause the start/stop button to jump right, and stopping the container the button jumps left, so you might click the wrong button (e.g. delete). With the new grid-based table component, column widths are fixed so content doesn't affect table width. This solves the previous issues, but it means that simple columns with long content are more likely to have overflow. This was 'fixed' in #4841 by setting a maximum column width and overflow-hidden to limit rendering to within the cell, but now things like popup menus can't go outside of the cells. I've struggled deciding what the correct default behaviour should be, but I still think #4841 is correct and means the average renderer can stay simple. This change adds a new 'overflow' property to allow renderers that are more interesting to control their own behaviour and render 'outside' of their cell. Property added to both image and volume action columns. Fixes #5220. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
requested review from
dgolovin and
lstocchi
and removed request for
a team
Closed
|
it is missing a test to check that overflow is added (or not) |
|
Works for me locally on Linux. |
Randomly picked Age column to allow overflow; test that the overflow is hidden on every other cell but not the age column cells. Signed-off-by: Tim deBoer <git@tdeboer.ca>
I spent a few minutes yesterday trying to think of a way to test something visually without thinking of this more obvious answer. :(. Test for overflow-hidden class added. |
benoitf
approved these changes
Dec 12, 2023
5 tasks
benoitf
pushed a commit
to benoitf/desktop
that referenced
this pull request
Dec 12, 2023
* fix: allow table columns to specify overflow With the previous table (<1.6), column widths were variable and this caused problems: - sometimes a long image name would cause the tables to require horizontal scrolling - sometimes a change in one column would cause other columns to shift E.g. starting a container can cause the start/stop button to jump right, and stopping the container the button jumps left, so you might click the wrong button (e.g. delete). With the new grid-based table component, column widths are fixed so content doesn't affect table width. This solves the previous issues, but it means that simple columns with long content are more likely to have overflow. This was 'fixed' in containers#4841 by setting a maximum column width and overflow-hidden to limit rendering to within the cell, but now things like popup menus can't go outside of the cells. I've struggled deciding what the correct default behaviour should be, but I still think containers#4841 is correct and means the average renderer can stay simple. This change adds a new 'overflow' property to allow renderers that are more interesting to control their own behaviour and render 'outside' of their cell. Property added to both image and volume action columns. Fixes containers#5220. Signed-off-by: Tim deBoer <git@tdeboer.ca>
benoitf
pushed a commit
that referenced
this pull request
Dec 12, 2023
* fix: allow table columns to specify overflow With the previous table (<1.6), column widths were variable and this caused problems: - sometimes a long image name would cause the tables to require horizontal scrolling - sometimes a change in one column would cause other columns to shift E.g. starting a container can cause the start/stop button to jump right, and stopping the container the button jumps left, so you might click the wrong button (e.g. delete). With the new grid-based table component, column widths are fixed so content doesn't affect table width. This solves the previous issues, but it means that simple columns with long content are more likely to have overflow. This was 'fixed' in #4841 by setting a maximum column width and overflow-hidden to limit rendering to within the cell, but now things like popup menus can't go outside of the cells. I've struggled deciding what the correct default behaviour should be, but I still think #4841 is correct and means the average renderer can stay simple. This change adds a new 'overflow' property to allow renderers that are more interesting to control their own behaviour and render 'outside' of their cell. Property added to both image and volume action columns. Fixes #5220. Signed-off-by: Tim deBoer <git@tdeboer.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
With the previous table (<1.6), column widths were variable and this caused problems:
With the new grid-based table component, column widths are fixed so content doesn't affect table width. This solves the previous issues, but it means that simple columns with long content are more likely to have overflow. This was 'fixed' in #4841 by setting a maximum column width and overflow-hidden to limit rendering to within the cell, but now things like popup menus can't go outside of the cells.
I've struggled deciding what the correct default behaviour should be, but I still think #4841 is correct and means the average renderer can stay simple. This change adds a new 'overflow' property to allow renderers that are more interesting to control their own behaviour and render 'outside' of their cell.
Property added to both image and volume action columns.
Screenshot / video of UI
Self-explanatory; popup menus don't appear.
What issues does this PR fix or reference?
Fixes #5220.
How to test this PR?
Test popup menus in Images list.