Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: edit Podman machine support for MacOS only #5239

Merged
merged 1 commit into from Dec 13, 2023

Conversation

jeffmaury
Copy link
Contributor

Fixes #5233

What does this PR do?

prevent Podman machine to be editable on Windows

Screenshot / video of UI

N/A

What issues does this PR fix or reference?

Fixes #5233

How to test this PR?

@jeffmaury jeffmaury requested review from benoitf and a team as code owners December 13, 2023 08:20
@jeffmaury jeffmaury requested review from dgolovin and feloy and removed request for a team December 13, 2023 08:20
Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked on macOS and it works

but it's requiring a test to ensure edit is added only for macOS

@slemeur slemeur mentioned this pull request Dec 13, 2023
@odockal
Copy link
Contributor

odockal commented Dec 13, 2023

Looking...

@odockal
Copy link
Contributor

odockal commented Dec 13, 2023

On windows Edit option is not visible anymore. LGTM.

@odockal odockal self-requested a review December 13, 2023 10:57
@benoitf benoitf mentioned this pull request Dec 13, 2023
4 tasks
Fixes containers#5233

Signed-off-by: Jeff MAURY <jmaury@redhat.com>
Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@benoitf benoitf merged commit 1d85984 into containers:main Dec 13, 2023
8 checks passed
@jeffmaury jeffmaury deleted the GH-5233 branch December 13, 2023 17:30
@podman-desktop-bot podman-desktop-bot added this to the 1.7.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editing podman machine on Windows ended up with an Error (exit code 125)
4 participants