fix: quick pick filter removes selection #5613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As you filter the quick pick would automatically select the first item that's left, but would never deselect, so (e.g.) if you type 'ddd' you're selecting whatever the last item that started with 'd' was (or the first item ever shown if there were none that started with d). This just adds the deselection if there are no items that match the filter. I decided to use the 'onSelectCallback' to test and found a second problem: the callback is not called when the selection is changed due to filtering. That is fixed and tested as well. Fixes #5610. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
requested review from
dgolovin and
cdrage
and removed request for
a team
benoitf
approved these changes
Jan 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As you filter the quick pick would automatically select the first item that's left, but would never deselect, so (e.g.) if you type 'ddd' you're selecting whatever the last item that started with 'd' was (or the first item ever shown if there were none that started with d). This just adds the deselection if there are no items that match the filter.
I decided to use the 'onSelectCallback' to test and found a second problem: the callback is not called when the selection is changed due to filtering. That is fixed and tested as well.
Screenshot / video of UI
N/A
What issues does this PR fix or reference?
Fixes #5610.
How to test this PR?
See issue for original problem; confirm tests catch this case.