Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: quick pick filter removes selection #5613

Merged
merged 1 commit into from Jan 21, 2024
Merged

fix: quick pick filter removes selection #5613

merged 1 commit into from Jan 21, 2024

Commits on Jan 21, 2024

  1. fix: quick pick filter removes selection 

    As you filter the quick pick would automatically select the first item
that's left, but would never deselect, so (e.g.) if you type 'ddd' you're
selecting whatever the last item that started with 'd' was (or the first
item ever shown if there were none that started with d). This just adds the
deselection if there are no items that match the filter.

I decided to use the 'onSelectCallback' to test and found a second problem:
the callback is not called when the selection is changed due to filtering.
That is fixed and tested as well.

Fixes #5610.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
    @deboer-tim
    deboer-tim committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    4fc19ef View commit details
    Browse the repository at this point in the history