feat: volume deletion #5707
Merged
feat: volume deletion #5707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the 'DELETING' state to volumes so that a spinner appears while they are being deleted. Follows the identical pattern to pods, deployments, etc: - Add new status. - Set the status when deleting and fire an event. - Propogate event through ColumnActions. - List/Details trigger UI change. Adds missing volume action test. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
requested review from
jeffmaury and
cdrage
and removed request for
a team
benoitf
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the 'DELETING' state to volumes so that a spinner appears while they are being deleted. Follows the identical pattern to pods, deployments, etc:
Adds missing volume action test.
Screenshot / video of UI
Screen.Recording.2024-01-26.at.8.18.52.AM.mov
What issues does this PR fix or reference?
Fixes #5614.
How to test this PR?
Create a volume, then delete it.