Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix volumes creating for client API #108

Merged
merged 2 commits into from
Jun 8, 2021
Merged

Conversation

sshnaidm
Copy link
Member

@sshnaidm sshnaidm commented Jun 7, 2021

No description provided.

When cycling over dictionary use .items(), otherwise there is an error
"ValueError: too many values to unpack"
@sshnaidm sshnaidm changed the title Allow empty options for volumes mount Fix volumes creating for client API Jun 7, 2021
@mwhahaha
Copy link
Collaborator

mwhahaha commented Jun 7, 2021

/lgtm

@jwhonce
Copy link
Member

jwhonce commented Jun 8, 2021

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwhonce, sshnaidm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 8, 2021
@jwhonce
Copy link
Member

jwhonce commented Jun 8, 2021

/lgtm

@jwhonce jwhonce merged commit 850f97c into containers:main Jun 8, 2021
@bguezzie
Copy link

bguezzie commented Jun 9, 2021

Not sure if this is the right place to ask, but what's the release cadence typically like for this project? My IDE doesn't automatically tell me when a new version is out, but this fix would be very helpful for me. I can work around for now by spinning up podman directly and using command line args, but would also like to have a [rough] idea for when this will be available in a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants