-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor text fixes in contributing.md #277
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
/lgtm |
@umohnani8: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
@umohnani8: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
@umohnani8 the repo settings probably need some tweaking. Other repos don't show the same |
@lsm5 yeah I am trying to figure out that setting to enable it |
i added the |
hmm, podman's own main branch doesn't have @umohnani8 did you change something as well ? |
Nope, I haven't changed anything yet |
Let me close and re-open this PR to see if some changes just took a while to show up |
@umohnani8 i'll defer to you, but feel free to keep or remove the tide check in https://github.com/containers/podman-py/settings/branch_protection_rules/19927551 in |
Fixed the merge bot as well, let's see if it merges this PR once lgtm is set and the tests pass