Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor text fixes in contributing.md #277

Closed
wants to merge 1 commit into from

Conversation

umohnani8
Copy link
Member

@umohnani8 umohnani8 commented May 31, 2023

Fixed the merge bot as well, let's see if it merges this PR once lgtm is set and the tests pass

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
@umohnani8 umohnani8 changed the title Testing prow merge Minor text fixes in contributing.md May 31, 2023
@umohnani8 umohnani8 marked this pull request as draft May 31, 2023 17:00
@umohnani8 umohnani8 marked this pull request as ready for review May 31, 2023 17:08
@umohnani8
Copy link
Member Author

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2023

@umohnani8: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2023

@umohnani8: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@umohnani8
Copy link
Member Author

@lsm5 @rhatdan can one of you please lgtm, I want to test the merge bot. I got yelled at for lgtm'ing my own PR 😆

@lsm5
Copy link
Member

lsm5 commented May 31, 2023

/lgtm

@lsm5
Copy link
Member

lsm5 commented May 31, 2023

@umohnani8 the repo settings probably need some tweaking. Other repos don't show the same merge disallowed message.

@umohnani8
Copy link
Member Author

@lsm5 yeah I am trying to figure out that setting to enable it

@lsm5
Copy link
Member

lsm5 commented May 31, 2023

i added the tide check to branch protection rules for main branch. don't know if it works yet

@lsm5
Copy link
Member

lsm5 commented May 31, 2023

i added the tide check to branch protection rules for main branch. don't know if it works yet

hmm, podman's own main branch doesn't have tide added.

@umohnani8 did you change something as well ?

@umohnani8
Copy link
Member Author

Nope, I haven't changed anything yet

@umohnani8
Copy link
Member Author

Let me close and re-open this PR to see if some changes just took a while to show up

@umohnani8 umohnani8 closed this May 31, 2023
@umohnani8 umohnani8 reopened this May 31, 2023
@umohnani8 umohnani8 closed this May 31, 2023
@lsm5
Copy link
Member

lsm5 commented May 31, 2023

@umohnani8 i'll defer to you, but feel free to keep or remove the tide check in https://github.com/containers/podman-py/settings/branch_protection_rules/19927551 in Required status checks. Might be good to block on it, but podman doesn't

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants