Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Containers Created Through REST API Have Umask Of 0000 #15036

Closed
p0da opened this issue Jul 22, 2022 · 0 comments · Fixed by #15040
Closed

Containers Created Through REST API Have Umask Of 0000 #15036

p0da opened this issue Jul 22, 2022 · 0 comments · Fixed by #15040
Assignees
@Luap99
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@p0da
Copy link

p0da commented Jul 22, 2022

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind bug

Description

Containers.conf has no umask entry which should cause podman to fallback to the default umask (0022):

$ podman system service --time 0 tcp:127.0.0.1:3000
$ curl 'http://127.0.0.1:3000/v4.0.0/libpod/containers/create' --json '{"name":"test","image":"alpine"}'
$ podman inspect test | jq '.[].Config.Umask'
"0000"

It instead sets umask to 0000. However containers created through the CLI seem to work correctly:

$ podman run --name test alpine
$ podman inspect test | jq '.[].Config.Umask'
"0022"
$ podman --version
podman version 4.1.1

(Arch so everything should be up to date)
@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 22, 2022
@p0da p0da changed the title Containers Created Through REST API Have Umask Of 000 Containers Created Through REST API Have Umask Of 0000 Jul 22, 2022
@Luap99 Luap99 self-assigned this Jul 22, 2022
Luap99 added a commit to Luap99/libpod that referenced this issue Jul 22, 2022
@Luap99
API: libpod/create use correct default umask
4d0cf8b 
Make sure cotnainers created via API have the correct umask from
contianers.conf set.

Fixes containers#15036

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99 added a commit to Luap99/libpod that referenced this issue Jul 22, 2022
@Luap99
API: libpod/create use correct default umask
d1f56a4 
Make sure containers created via API have the correct umask from
containers.conf set.

Fixes containers#15036

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99 added a commit to Luap99/libpod that referenced this issue Jul 22, 2022
@Luap99
API: libpod/create use correct default umask
5a80770 
Make sure containers created via API have the correct umask from
containers.conf set.

Fixes containers#15036

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@Luap99 Luap99 mentioned this issue Jul 22, 2022
Merged
mheon pushed a commit to mheon/libpod that referenced this issue Jul 26, 2022
@Luap99 @mheon
API: libpod/create use correct default umask
c461651 
Make sure containers created via API have the correct umask from
containers.conf set.

Fixes containers#15036

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Luap99 Luap99

Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

API: libpod/create use correct default umask Luap99/libpod
2 participants
@Luap99 @p0da