Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

podman stats is incompatible with Docker #4274

Closed
AkihiroSuda opened this issue Oct 16, 2019 · 1 comment · Fixed by #4275
Closed

podman stats is incompatible with Docker #4274

AkihiroSuda opened this issue Oct 16, 2019 · 1 comment · Fixed by #4275
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@AkihiroSuda
Copy link
Collaborator

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind bug

Description

podman stats requires containers to be specified while docker stats shows all running containers by default.

Also, the man page describes the behavior of Docker, not the current behavior of Podman.
https://github.com/containers/libpod/blob/7e238b9e0c650b20f1a325dad14ef94a3e7d1aab/docs/podman-stats.1.md

Steps to reproduce the issue:

podman stats

Describe the results you received:
Error: you must provide at least one name or id

https://github.com/containers/libpod/blob/5f72e6ef2ef7b6941cefc3c655903aeacb53e115/cmd/podman/stats.go#L48
https://github.com/containers/libpod/blob/fd389d28ce2223550c82d809cbafa12a54e733e6/cmd/podman/common.go#L43-L63

Describe the results you expected:
Should show all running containers as in docker stats

Additional information you deem important (e.g. issue happens only occasionally):

Output of podman version:

Version: 1.6.1
...
@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 16, 2019
vrothberg added a commit to vrothberg/libpod that referenced this issue Oct 16, 2019
@vrothberg
stats: list all running containers unless specified otherwise
c2f16d6 
Unless specified otherwise by --all, --latest or via arguments, list all
running containers.  This matches the behaviour of Docker and is also
illustrated in the man pages where containers and options are marked to
be optional.

Fixes: containers#4274
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
@vrothberg vrothberg mentioned this issue Oct 16, 2019
Merged
@vrothberg
Copy link
Member

Thanks for opening the issue, @AkihiroSuda. I opened #4275 to fix it.

vrothberg added a commit to vrothberg/libpod that referenced this issue Oct 16, 2019
@vrothberg
stats: list all running containers unless specified otherwise
e8b3d07 
Unless specified otherwise by --all, --latest or via arguments, list all
running containers.  This matches the behaviour of Docker and is also
illustrated in the man pages where containers and options are marked to
be optional.

Fixes: containers#4274
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
vrothberg added a commit to vrothberg/libpod that referenced this issue Oct 23, 2019
@vrothberg
stats: list all running containers unless specified otherwise
77a2bbb 
Unless specified otherwise by --all, --latest or via arguments, list all
running containers.  This matches the behaviour of Docker and is also
illustrated in the man pages where containers and options are marked to
be optional.

Fixes: containers#4274
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
rh-container-bot pushed a commit to lsm5/podman that referenced this issue Nov 17, 2019
@vrothberg @rh-container-bot
stats: list all running containers unless specified otherwise
8a49c5e 
Unless specified otherwise by --all, --latest or via arguments, list all
running containers.  This matches the behaviour of Docker and is also
illustrated in the man pages where containers and options are marked to
be optional.

Fixes: containers#4274
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

stats: list all running containers unless specified otherwise vrothberg/libpod
3 participants
@AkihiroSuda @vrothberg @openshift-ci-robot