Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stats: list all running containers unless specified otherwise #4275

Merged
merged 1 commit into from
Oct 23, 2019
Merged

stats: list all running containers unless specified otherwise #4275

merged 1 commit into from
Oct 23, 2019

Conversation

vrothberg
Copy link
Member

Unless specified otherwise by --all, --latest or via arguments, list all
running containers. This matches the behaviour of Docker and is also
illustrated in the man pages where containers and options are marked to
be optional.

Fixes: #4274
Signed-off-by: Valentin Rothberg rothberg@redhat.com

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S labels Oct 16, 2019
@vrothberg vrothberg mentioned this pull request Oct 16, 2019
Closed
giuseppe
giuseppe reviewed Oct 16, 2019
View reviewed changes
cmd/podman/stats.go Outdated Show resolved Hide resolved
@TomSweeneyRedHat
Copy link
Member

LGTM other than the lint hiccup

@vrothberg
Copy link
Member Author

The linter should be happy now :)

@rhatdan
Copy link
Member

rhatdan commented Oct 16, 2019

/lgtm
/hold
hold cancel when tests pass.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 16, 2019
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2019
@baude
Copy link
Member

baude commented Oct 22, 2019

@vrothberg mind peeking at these test failures and seeing if they are legit and would require a fix?

@vrothberg
Copy link
Member Author

@vrothberg mind peeking at these test failures and seeing if they are legit and would require a fix?

Eeek, took me a while to wrap my head around the problem (it passes locally). The system test to parse the help messages gets into an infinite loop when hitting stats now. Will update accordignly.

@vrothberg
stats: list all running containers unless specified otherwise
77a2bbb 
Unless specified otherwise by --all, --latest or via arguments, list all
running containers.  This matches the behaviour of Docker and is also
illustrated in the man pages where containers and options are marked to
be optional.

Fixes: containers#4274
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2019
@vrothberg
Copy link
Member Author

Green!
/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2019
@vrothberg
Copy link
Member Author

@rhatdan @TomSweeneyRedHat @baude @giuseppe needs a lgtm for merging

@TomSweeneyRedHat
Copy link
Member

LGTM

@rhatdan
Copy link
Member

rhatdan commented Oct 23, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2019
@openshift-merge-robot openshift-merge-robot merged commit ef556cf into containers:master Oct 23, 2019
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@giuseppe giuseppe giuseppe left review comments

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

podman stats is incompatible with Docker
7 participants
@vrothberg @openshift-ci-robot @TomSweeneyRedHat @rhatdan @baude @giuseppe @openshift-merge-robot