-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shortnames are broken in 3.0.0 due to missing list of unqualified-search registries #9390
Comments
Is this on Debian? Ubuntu? The registries.conf file is invalid it should have at least that registry in the list/ |
I think this is a dupe, but I can't find the other bug. Regardless, this is not the first I've heard of this - it seems like we're having packaging issues in OBS. @lsm5 PTAL |
I'm observing this on both distros, the repos are:
The https://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/stable/Debian_10/all/containers-common_1-7_all.deb file doesn't seem to contain |
* Work around containers/podman#9390 * Work around containers/podman#9393 * Stream launched container's logs to the CLI's logger * Work around containers/podman#9351 * Ignore bodyclose linter false-positive * .cirrus.yml: run "go test" on Windows verbosely * Use sub-context for the ContainerLogs() call To avoid potential hangs in stdcopy.StdCopy(). * ContainerLogs: use buffered channels To avoid a case when stdcopy.StdCopy() waits for the io.Pipe() to unlock, while the connection from which it reads the logs gets closed. This presumably results in the tail part of the logs getting lost. * TestContainerLogs: skip last line check for Podman
Should be fixed with podman I'll keep the bug open for now. Please close it if this resolves your issue. |
Thanks! Closing because it works now. |
Is this issue back? Maybe the message should suggest what most people probably want anyway: "Try docker.io/python:latest instead". |
This is up to the distribution to decide. We don't want to force user to docker.io. A reasonable site might decide to have no default registry, so this error message is valid. |
@rhatdan yours is the principled approach but it's also ignorant to people who just want to get things done. I lost 20 minutes on this because I didn't know if docker uses hub.docker.com or docker.io or ... as default and neither did I know how to provide the url. Is it url:image:version or url/with/repo/path:image:version, ... I never cared and never had to and when searching for a python image, the run instructions usually do not include that part neither. The current error message is just a terrible time-waster and frustrates the user, especially if he's trying to migrate from docker where it "just works". Add a link to an explainer with examples please! |
Note that there is a security issue behind these changes: https://www.redhat.com/sysadmin/container-image-short-names Which distribution are you running on, @Giszmo? I sympathize with the frustration but our hands are tied. Do you think pointing to the For the record, the fix in this case would be adding the following line to /etc/containers/registries.conf: |
@Giszmo How did you get the Podman that you are using? I would figure most naive users get their Podman from a distribution? If a distribution gave you a version without a configured registry, then I could see this as a problem. If you just grabbed the static version, then you have a point, but there are lots of config files that we need that are not shipped with a static version. |
I run podman on my Ubuntu 20.04. So if others have the same issue, Ubuntu should be poked. I'm fine with @vrothberg's config I guess. Thanks. |
Where did you get the Podman from? It looks like it did not pull in containers-common which should have the registries.conf settings. |
what exactly should I check? |
I don't know apt, but this looks like containers-common is installed, did it come with a registries.conf file? @lsm5 PTAL |
The
but those define no such defaults:
so if I read that correctly, it makes things work as with docker before, for select few images (alpine, hello-world, ...) but does not default to docker.io for non-listed images. |
Right this is a packaging issue with Ubuntu. It should ship /etc/containers/registries.comf |
Quick fix for the majority of users is to alter one line: |
Even better, add a file /etc/containers/registries.conf.d/docker.conf with just the line |
So for this issue do we edit the .conf or the .conf.d? |
Either is fine. |
I guess you need to edit the registries.conf, or there is something wrong with the file. |
It looks more like the |
@BiggerPicture2, the last line 79 shouldn't be there. shortnames.conf should only be for shortnames. |
Without a reproducer and/or the exact file, there's not much I can do. The error message includes the path to the config file that fails to be loaded. |
you would need to see the container file or the shortnames.conf? |
For Podman Desktop on MacOS you can get the docker behaviour... |
3.0.0 changelog states that:
As described in the RedHat blog about this feature, the user can expect some form of fallback in case no shortname alias is defined:
However, because the 3.0.0 installation is missing these registries, pulling
python:latest
(or any other image not currently included in the shortnames list) results in an unexpected result:The package that presumably should ship the registries configuration:
It would be nice if this list would be included and contain at least something like:
...to adhere to the principle of least astonishment.
The text was updated successfully, but these errors were encountered: