Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4.0-rhel] vendor c/common@v0.47.5 #13608

Merged

Conversation

vrothberg
Copy link
Member

Update the login tests to reflect the latest changes to allow http{s}
prefixes (again) to address bugzilla.redhat.com/show_bug.cgi?id=2062072.

Backport of commit 57cdc21.

Signed-off-by: Valentin Rothberg vrothberg@redhat.com

Update the login tests to reflect the latest changes to allow http{s}
prefixes (again) to address bugzilla.redhat.com/show_bug.cgi?id=2062072.

Backport of commit 57cdc21.

Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2022
@rhatdan
Copy link
Member

rhatdan commented Mar 23, 2022

@TomSweeneyRedHat do you want to block this?

@TomSweeneyRedHat
Copy link
Member

@rhatdan yes, until we get approval from RHEL mgmt. @vrothberg in the meantime, can you spin one up on the v4.0-rhel branch too please? That should be held also for the moment.

@TomSweeneyRedHat TomSweeneyRedHat added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 23, 2022
@vrothberg
Copy link
Member Author

@rhatdan yes, until we get approval from RHEL mgmt. @vrothberg in the meantime, can you spin one up on the v4.0-rhel branch too please? That should be held also for the moment.

This PR is for the v4.0-rhel branch :)

@vrothberg
Copy link
Member Author

/hold

@TomSweeneyRedHat
Copy link
Member

Ooops, too many PR @vrothberg . Did you make one for the v4.0 branch then? If not, please do.

@vrothberg
Copy link
Member Author

#13614 :)

@TomSweeneyRedHat
Copy link
Member

@TomSweeneyRedHat
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2022
@TomSweeneyRedHat
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2022
@openshift-merge-robot openshift-merge-robot merged commit 5a54f81 into containers:v4.0-rhel Mar 24, 2022
@vrothberg vrothberg deleted the v4.0-backports branch March 24, 2022 15:34
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants