libpod: Report network setup errors properly on FreeBSD #16554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luap99
reviewed
Nov 18, 2022
dfr
force-pushed
the
freebsd-network-errors
branch
from
b63046f
to
a06bc62
Compare
|
LGTM |
rhatdan
reviewed
Nov 18, 2022
rhatdan
reviewed
Nov 18, 2022
rhatdan
reviewed
Nov 18, 2022
Some error reporting logic got lost from (*Container).prepare during the port. This adds the missing logic, similar to the Linux version. [NO NEW TESTS NEEDED] Signed-off-by: Doug Rabson <dfr@rabson.org>
dfr
force-pushed
the
freebsd-network-errors
branch
from
a06bc62
to
504fcbb
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dfr, flouthoc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
dfr
added a commit
to dfr/podman
that referenced
this pull request
Nov 28, 2022
This addresses containers#16333 although that issue was also avoided by changes in PR containers#16554. Signed-off-by: Doug Rabson <dfr@rabson.org>
dfr
added a commit
to dfr/podman
that referenced
this pull request
Nov 28, 2022
This addresses containers#16333 although that issue was also avoided by changes in PR containers#16554. Signed-off-by: Doug Rabson <dfr@rabson.org>
dfr
added a commit
to dfr/podman
that referenced
this pull request
Nov 28, 2022
This addresses containers#16333 although that issue was also avoided by changes in PR containers#16554. [NO NEW TESTS NEEDED] Signed-off-by: Doug Rabson <dfr@rabson.org>
dfr
added a commit
to dfr/podman
that referenced
this pull request
Nov 28, 2022
…fails This addresses containers#16333 although that issue was also avoided by changes in PR containers#16554. [NO NEW TESTS NEEDED] Signed-off-by: Doug Rabson <dfr@rabson.org>
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some error reporting logic got lost from (*Container).prepare during the port. This adds the missing logic, similar to the Linux version.
[NO NEW TESTS NEEDED]
Signed-off-by: Doug Rabson dfr@rabson.org
Does this PR introduce a user-facing change?