[CI:DOCS] hack/perf/bz-2162111.sh: use custom network #17335
Conversation
openshift-ci
bot
added
release-note-none
approved
hack/perf/bz-2162111.sh
Outdated
| $ENGINE_A network rm -f $network_name >> /dev/null || true | ||
| $ENGINE_B network rm -f $network_name >> /dev/null || true | ||
| $ENGINE_A network create $network_name >> /dev/null | ||
| $ENGINE_B network create $network_name >> /dev/null |
There was a problem hiding this comment.
Any reason to not use random names? That would prevent all name conflicts.
Also I am missing where you remove the network after the test is done?
There was a problem hiding this comment.
Any reason to not use random names? That would prevent all name conflicts.
Easier debugging to know where it came from.
Also I am missing where you remove the network after the test is done?
I didn't intend to since it'll get remove on the next invocation. The other scripts may also leave containers etc. in storage.
There was a problem hiding this comment.
I'm with @Luap99 on this one. It is polite to clean up after oneself.
There was a problem hiding this comment.
I don't like leaking test resources for no reason.
I expected all test to cleanup what they created, I understand keeping images because pulling is expensive but the rest not so much.
There was a problem hiding this comment.
Please note the ./hack , it's not in ./test. I am not arguing against any of these points but ask to apply different standards to these hacked scripts.
I'll repush with cleaning up nonetheless 👍
There was a problem hiding this comment.
Updated. Added a commit on top to also clean up after the other benchmarks.
Create the containers with a custom network. It has an impact on the speed of container creation. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
To leave not leave some artifacts arounds. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
vrothberg
force-pushed
the
hack/perf/bz-2162111.sh
branch
from
e3e2125
to
8aa3776
Compare
|
LGTM |
|
@giuseppe PTAL |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-actions
bot
added
the
locked - please file new issue/PR
Create the containers with a custom network. It has an impact on the speed of container creation.
Signed-off-by: Valentin Rothberg vrothberg@redhat.com
@baude @edsantiago PTAL
Does this PR introduce a user-facing change?