Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rootless: add new netmode "slirp4netns" #1849

Merged
merged 3 commits into from
Nov 28, 2018
Merged

rootless: add new netmode "slirp4netns" #1849

merged 3 commits into from
Nov 28, 2018

Conversation

giuseppe
Copy link
Member

so that inspect reports the correct network configuration.

Closes: #1453

Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com

@giuseppe giuseppe mentioned this pull request Nov 21, 2018
Closed
@giuseppe giuseppe changed the title rootless: add new netmode "rootless" [WIP] rootless: add new netmode "rootless" Nov 21, 2018
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2018
@giuseppe
Copy link
Member Author

I've marked it as WIP as I want to work more on this PR and add tests

@rhatdan
Copy link
Member

rhatdan commented Nov 21, 2018

So far LGTM

@giuseppe giuseppe force-pushed the report-rootless-netmode branch 3 times, most recently from c445205 to c857072 Compare November 22, 2018 14:36
@giuseppe giuseppe changed the title [WIP] rootless: add new netmode "rootless" rootless: add new netmode "rootless" Nov 23, 2018
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 23, 2018
@giuseppe
Copy link
Member Author

I wonder if we should open the possibility of using slirp4netns also to the root user and not having this special case only for rootless containers.

@giuseppe giuseppe changed the title rootless: add new netmode "rootless" rootless: add new netmode "slirp4netns" Nov 23, 2018
@giuseppe giuseppe force-pushed the report-rootless-netmode branch 4 times, most recently from ab9fc8d to 0f18bf2 Compare November 27, 2018 14:02
@AkihiroSuda
Copy link
Collaborator

Is slirp4netns useful for rootful mode?

@giuseppe
Copy link
Member Author

Is slirp4netns useful for rootful mode?

I think it is not. I've only wanted to make it possible to use, if the user wishes so, but I cannot find any reason why do it.

@rhatdan
Copy link
Member

rhatdan commented Nov 27, 2018

Well I don't think we want it default, but would it be useful for running inside of a container which had not net-admin capabiltiies?

@giuseppe
Copy link
Member Author

but would it be useful for running inside of a container which had not net-admin capabiltiies?

probably yes. It should enable the use case of running podman as root without having CAP_NET_ADMIN

@giuseppe
tests: change return type for PodmanAsUser to PodmanTestIntegration
266c495 
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe
rootless: add new netmode "slirp4netns"
4203df6 
so that inspect reports the correct network configuration.

Closes: containers#1453

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe force-pushed the report-rootless-netmode branch 2 times, most recently from b01a578 to 12957d5 Compare November 27, 2018 20:33
@giuseppe
network: allow slirp4netns mode also for root containers
95f22a2 
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe
Copy link
Member Author

all tests are green!

@rhatdan
Copy link
Member

rhatdan commented Nov 28, 2018

LGTM
@mheon @umohnani8 @baude @vrothberg PTAL

@vrothberg
Copy link
Member

LGTM

@vrothberg
Copy link
Member

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2018
@giuseppe
Copy link
Member Author

@rhatdan @vrothberg there are two LGTM, can someone do the / lgtm? :-)

@TomSweeneyRedHat
Copy link
Member

LGTM and all happy green test buttons.

@vrothberg
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2018
@vrothberg
Copy link
Member

Ah. Didn't know one person can approve and do the lgtm.

@openshift-merge-robot openshift-merge-robot merged commit d346996 into containers:master Nov 28, 2018
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@baude baude Awaiting requested review from baude

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees

@vrothberg vrothberg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@giuseppe @rhatdan @AkihiroSuda @vrothberg @openshift-ci-robot @TomSweeneyRedHat @openshift-merge-robot