update c/{common,image,storage} to latest #18835
Conversation
openshift-ci
bot
added
release-note-none
approved
|
Yikes that is some bloating. |
Only for rootlessport though. Somehow some massive transitive dependency must have been slipped in there. I can take a look but for now we should focus on getting this in first. @lsm5 Any ideas about the rpm failures? They are consistent and only on this vendor update PR. The centos builds are complaining about btrfs which seems weird, that should be excluded via build tag? |
|
On fedora and c9s I see: and the btrfs/ioctl.h in c8s. Looks like something went wrong with buildtags ? |
Yes I assume that is the case but I could not find the error in the build logs. |
|
@Luap99 ack, I'll check if the spec file needs further adjustment. I think it might be useful to have copr build tasks on each of the libraries: mainly check if any PR breaks a podman (and/or buildah and/or skopeo) rpm build. |
|
Is there any way to see the build tags in the log? I cannot see any build tags set. |
|
Yes build issue and rootlessport bloat is because of containers/storage#1618 (comment). We now need to set the build tags for rootlessport as well but I rather try to get the c/storage change fixed to avoid the 3 MB bloat in rootlessport. |
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
A c/storage PR[1] chnage the behavior to correctly report umount errors. This is causing problem in the updgrade tests. The problem is that a cotnainer is mounted inside another container and then unmounted on the host. Therefore both operations happen in different mount namespaces. this is expcted but we want to share the mounts between them. This is the default but c/stroage make the root private by default thus the mounts were not shared. To fix this use the `skip_mount_home` storage option so the mount is kept shared. [1] containers/storage#1607 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
add routes using the --route flag. the no_default_route option in --opt prevents a default route from getting added automatically. Signed-off-by: Jan Hendrik Farr <github@jfarr.cc>
Because of a c/storage change[1] all we get a lot of new dependencies in rootlessport despite not using them. Add build tags to exclude storage drivers to make the binary smaller until it get addressed in c/storage. This saves about 800 MB but the bloat due that change is still causing us to gain over 2 MB. This is not ideal but we should get vendoring going and not wait any longer. [1] containers/storage#1618 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99
force-pushed
the
update-container-deps
branch
from
6fe8b09
to
ebf7474
Compare
Luap99
added
the
bloat_approved
|
@containers/podman-maintainers PTAL |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Document `--route` for `podman network create`. Feature included via PR: containers#18835 Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
Document `--route` for `podman network create`. Feature included via PR: containers#18835 Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
github-actions
bot
added
the
locked - please file new issue/PR
Also contains cherry-pick of #18369 to make validate happy.
And another fix for the upgrade tests.
Does this PR introduce a user-facing change?