-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vendor c/common pasta branch for testing #21563
Vendor c/common pasta branch for testing #21563
Conversation
1a798f5
to
27f523c
Compare
Cockpit tests failed for commit 27f523c. @martinpitt, @jelly, @mvollmer please check. |
27f523c
to
7a5015d
Compare
Cockpit tests failed for commit 7a5015d. @martinpitt, @jelly, @mvollmer please check. |
Looks like I broke remote, but everything else seems solid |
7a5015d
to
c70cd90
Compare
Cockpit tests failed for commit c70cd90. @martinpitt, @jelly, @mvollmer please check. |
I'm actually not sure how this APIv2 test passed in the first place. We don't populate the NetworkSettings.Networks field for slirp4netns either per my testing. |
see 2165170 |
Seems like the test failures are no mostly things that expect slirp4netns default so we need to change them, the timeouts in the sys tests are however very concerning because they do not seem to hang at a specific point and just are much slower. |
a31c715
to
ae3891b
Compare
Cockpit tests failed for commit a31c715. @martinpitt, @jelly, @mvollmer please check. |
Cockpit tests failed for commit ae3891b. @martinpitt, @jelly, @mvollmer please check. |
ae3891b
to
c0a6d5a
Compare
Cockpit tests failed for commit c0a6d5a. @martinpitt, @jelly, @mvollmer please check. |
c0a6d5a
to
67e07cd
Compare
Cockpit tests failed for commit 67e07cd. @martinpitt, @jelly, @mvollmer please check. |
APIv2 failure is legitimate, |
System tests are hard-stuck on |
I see nothing in there that Pasta ought to have broken... |
Odd, can you reproduce locally? |
The 700-play file passes locally without issue (and don't seem to take unduly long either) |
If nothing helps there is this re-run with terminal access feature in the cirrus web ui. It should allow you to look around while the tests are running. |
67e07cd
to
ab6f00a
Compare
Cockpit tests failed for commit ab6f00a. @martinpitt, @jelly, @mvollmer please check. |
Yep that 100% broke us. |
Cockpit tests failed for commit e6cbaa8. @martinpitt, @jelly, @mvollmer please check. |
Signed-off-by: Matt Heon <mheon@redhat.com>
e6cbaa8
to
03f6589
Compare
I think I fixed it. |
/lgtm |
|
Registry issues, as usual |
Cockpit tests failed for commit 03f6589. @martinpitt, @jelly, @mvollmer please check. |
Two flakes restarted. |
b736c46
into
containers:main
This caused a major regression, just filed as issue #21896 |
@@ -41,6 +41,8 @@ type Event struct { | |||
Type Type | |||
// Health status of the current container | |||
HealthStatus string `json:"health_status,omitempty"` | |||
// Error code for certain events involving errors. | |||
Error error `json:"error,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This cannot work with the file logger as you cannot unmarshal into an error interface so it must be changed to a string. And in general I am really not a fan of merging such changes (in an unrelated PR) without any tests nor chance for actual review.
I know we just wanted pasta to get in but that could have just gone it normal way without causing all the extra troubles by simply not merging unverified/untested changes in c/common without thinking how they effect podman.
Also the whole thing is not plumbed in at all, you never set this option from the libimage type so the error is lost and also not plugged into podman the cli nor API which means it will not show any error messages, users only see pull-error $IMAGE
right now.
I am aware that your goal was to just get test passing but I write this because this "feature" if far from done and needs tests.
Not today, I could do it next week. Nothing is really broken with that it is just the the error message is not being passed through to the consumer. I don't think it is a big deal if it missed rc4 but should definitely be there for the final release. |
Works for me. |
The introduction of pasta [1] regressed user containers if there is no default route [2]. While that is being sorted out, add a fake interface with a default route for our offline tests, to unbreak upstream podman PRs testing. [1] containers/podman#21563 [2] containers/podman#21896
The introduction of pasta [1] regressed user containers if there is no default route [2]. While that is being sorted out, add a fake interface with a default route for our offline tests, to unbreak upstream podman PRs testing. Fixes cockpit-project#1595 [1] containers/podman#21563 [2] containers/podman#21896
The introduction of pasta [1] regressed user containers if there is no default route [2]. While that is being sorted out, add a fake interface with a default route for our offline tests, to unbreak upstream podman PRs testing. Fixes #1595 [1] containers/podman#21563 [2] containers/podman#21896
Test swapping the default from Slirp4netns to Pasta
Does this PR introduce a user-facing change?