Add missing vfkit entitlement #21843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've now tested this with : |
When there is no signing identity to pass to the macOS `codesign` tool, we can use `-` instead as the identity to perform ad-hoc signing. From `man codesign`: > If identity is the single letter "-" (dash), ad-hoc signing is > performed. Ad-hoc signing does not use an identity at all This makes it easier to test the sign() code-path in package.sh as we'll run the same code regardless of `NO_CODESIGN` being set or not. Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
That's a left-over from 8794776 Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
cfergeau
force-pushed
the
entitlements
branch
2 times, most recently
from
8b26a13
to
24d3cc8
Compare
vfkit needs the com.apple.security.virtualization entitlement or it
wont' be able to start virtual machines:
Error: Error Domain=VZErrorDomain Code=2 Description="Invalid virtual machine configuration. The process doesn’t have the “com.apple.security.virtualization” entitlement." UserInfo={
NSLocalizedFailure = "Invalid virtual machine configuration.";
NSLocalizedFailureReason = "The process doesn\U2019t have the \U201ccom.apple.security.virtualization\U201d entitlement.";
}
This fixes containers#21842
Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
cfergeau
force-pushed
the
entitlements
branch
from
24d3cc8
to
9f5c20f
Compare
|
LGTM |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Cockpit tests failed for commit 94c219f. @martinpitt, @jelly, @mvollmer please check. |
openshift-merge-bot
bot
merged commit abd681a
into
containers:main
90 of 93 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vfkit binary shipped with podman 5.0-rc3 can't start virtual machines, see
#21842
The entitlements are overwritten during the signing process.
Does this PR introduce a user-facing change?