Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing vfkit entitlement #21843

Merged
merged 3 commits into from
Feb 27, 2024
Merged

Add missing vfkit entitlement #21843

merged 3 commits into from
Feb 27, 2024

Commits on Feb 27, 2024

  1. macos installer: Default to using ad-hoc signing 

    When there is no signing identity to pass to the macOS `codesign` tool,
we can use `-` instead as the identity to perform ad-hoc signing.

From `man codesign`:
> If identity is the single letter "-" (dash), ad-hoc signing is
> performed.  Ad-hoc signing does not use an identity at all

This makes it easier to test the sign() code-path in package.sh as
we'll run the same code regardless of `NO_CODESIGN` being set or not.

Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
    @cfergeau
    cfergeau committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    74b8787 View commit details
    Browse the repository at this point in the history

  2. macos-installer: Remove hvf.entitlements 

    That's a left-over from 8794776

Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
    @cfergeau
    cfergeau committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    15734f8 View commit details
    Browse the repository at this point in the history

  3. macos installer: Add vfkit entitlement 

    vfkit needs the com.apple.security.virtualization entitlement or it
wont' be able to start virtual machines:

Error: Error Domain=VZErrorDomain Code=2 Description="Invalid virtual machine configuration. The process doesn’t have the “com.apple.security.virtualization” entitlement." UserInfo={
    NSLocalizedFailure = "Invalid virtual machine configuration.";
    NSLocalizedFailureReason = "The process doesn\U2019t have the \U201ccom.apple.security.virtualization\U201d entitlement.";
}

This fixes containers#21842

Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
    @cfergeau
    cfergeau committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    9f5c20f View commit details
    Browse the repository at this point in the history