-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v5.0] Fix machine volumes with long path and paths with dashes #22568
Conversation
Backport of #22288 |
Ephemeral COPR build failed. @containers/packit-build please check. |
@ashley-cui I think you have to apply 41145d7 here as well to get the bud tests passing |
This is a RHEL release-branch, with test failing for unknown reason, not currently worth effort to debug. Signed-off-by: Chris Evich <cevich@redhat.com>
AppleHV accepts a max 36 bytes for mount tags. Instead of using the fully qualified path for the mount tag, SHA256 the path, and truncate the shasum to 36 bytes. Also correctly escape dashes in mounted paths. Signed-off-by: Ashley Cui <acui@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashley-cui, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
please merge this already :) |
@containers/podman-maintainers PTAL and merge :) |
LGTM |
/lgtm |
a6f64a5
into
containers:v5.0
AppleHV accepts a max 36 bytes for mount tags. Instead of using the fully qualified path for the mount tag, SHA256 the path, and truncate the shasum to 36 bytes. Also correctly escape dashes in mounted paths.
Fixes: #22226
Fixes: #22505
Does this PR introduce a user-facing change?