-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix create&run getting --authfile from cli #3737
Conversation
/approve Can we get a test for this, potentially? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mheon, QiWang19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mheon maybe add test in test/e2e/login_logout_test.go? there already set up the registry |
Works for me - either extending an existing test with a 'podman run' test or adding a fresh one |
Can you rebase? I think tests on master are green |
@QiWang19 Needs a rebase. |
ed873f2
to
97b1aaf
Compare
Add flag `--authfile` to create and run so Podman can read authfile path from not only environemnt variable REGISTRY_AUTH_FILE but also CLI Signed-off-by: Qi Wang <qiwan@redhat.com>
Needs lgtm label. |
/lgtm |
close #3730
Add flag
--authfile
to create and run so Podman can read authfile path from not only environment variable REGISTRY_AUTH_FILE but also CLISigned-off-by: Qi Wang qiwan@redhat.com