-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
honor pull policy in play kube #4993
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM |
LGTM besides possibly more test coverage 😄 |
also given this comment #4880 (comment) I'd either like special case handling for |
did this per our discussion too! |
one blocking nit, one non-blocking nit, otherwise LGTM 🥂 |
When a container specification has a pull policy, we should honor it when recreating the pods/containers from yaml. furthermore, ini kube, if a tag is :latest, then the always pull policy is automatically instituted. Fixes: containers#4880 Signed-off-by: Brent Baude <bbaude@redhat.com>
comments addressed in record time, LGTM |
/lgtm |
/hold cancel |
When a container specification has a pull policy, we should honor it when recreating the pods/containers from yaml.
Fixes: #4880
Signed-off-by: Brent Baude bbaude@redhat.com