-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spec: require golang-github-cpuguy83-md2man #122
Conversation
@sandrobonazzola RE: go-md2man, did Also, rpmautospec-rpm-macros doesn't seem to be available on el9 yet. |
|
@sandrobonazzola could you please point me to the exact issue you were seeing with autospec usage without the rpmautospec-rpm-macros build dependency? |
|
hmm, wonder why that never showed up on copr builds. I would prefer not to enable epel on the packit-builds copr used in CI. I'll PR to remove autospec for el9. |
@pypingou RE: qm / hirte and other tools, has there been any further movement on creating a unified copr? If there's gonna be a separate copr (and not something owned by |
@lsm5 I noticed this issue in the past: #85 but never fixed as it's never affected the software. However, if we can fix it's even better. Yes, it shows in the CI/CD build logs. |
@sandrobonazzola Could you please check the error msg from the builds?
|
[Following the thread to learn] /cc @rhatdan |
ack RE: shipping. How about the copr used in CI for PRs? The current copr is |
I am all for official location. |
We have the automotive SIG repository which is where I've built the On Copr we have a group: https://copr.fedorainfracloud.org/groups/g/centos-automotive-sig/coprs/ but there is no single copr repo, copr is for experiment, we want things that are not just experiments to land either in the automotive SIG or in AutoSD proper. |
4313cdc
to
316e5c9
Compare
As a first step, maybe it's worth switching Packit copr tasks to use the automotive-sig coprs in https://github.com/containers/qm/blob/main/.packit.yaml . Currently, it uses |
@lsm5 +1 |
@pypingou can we officially replace |
@lsm5 are you looking to this task? Should we create an issue in GH? |
@dougsland I'd rather someone else more active on qm take the lead here. |
It would involve setting up the new copr(s) and then updating .packit.yaml to use those coprs. |
explicitly require `golang-github-cpuguy83-md2man` instead of `%{_bindir}/go-md2man` and added a note about where to find it on CentOS Stream 9. Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
Follow up on containers#122 review. Adding instructions for enabling CRB repository on CS9. Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
316e5c9
to
485797d
Compare
@lsm5 could you please just open an issue against QM with your view and steps which we should approach? I can take the lead to make it happen. |
@sandrobonazzola thanks for your patches, merging now ! |
explicitly require
golang-github-cpuguy83-md2man
instead of%{_bindir}/go-md2man
and added a note about where to find it on CentOS Stream 9.Fixes #120