Implement a lookaside storage for signatures of images in Docker registries #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO? This would very much benefit from an integration test. |
mtrmac
force-pushed
the
docker-lookaside
branch
3 times, most recently
from
4f5b0e1
to
973fc26
Compare
|
Rebased, now depends only on containers/image#52 . Still would benefit from an integration test. |
mtrmac
force-pushed
the
docker-lookaside
branch
4 times, most recently
from
b021b71
to
2faf928
Compare
Merged
|
Tests now exist (in #177), but depend on pushing to tags in Docker registries. But with a hackish way to do that, they pass; so this PR + the containers/image implementation is ready for review and merging. |
Closed
mtrmac
force-pushed
the
docker-lookaside
branch
from
2faf928
to
df71348
Compare
mtrmac
force-pushed
the
docker-lookaside
branch
4 times, most recently
from
2638572
to
91ebebc
Compare
|
Updated per projectatomic/atomic#594 , adds Integration tests are still in #177 and don’t work against @runcom low-priority ping |
mtrmac
force-pushed
the
docker-lookaside
branch
from
91ebebc
to
f1b5e9c
Compare
This is added pretty much only for integration tests right now; though, it might be useful also for non-root operation. Also makes a tiny cleanup of contextFromGlobalOptions, removing a variable.
mtrmac
force-pushed
the
docker-lookaside
branch
from
f1b5e9c
to
b6fdea0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This vendors in unmerged containers/image#52 and updates the API usage. See the documentation in that PR for more details.